Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add planar movement #882

Merged
merged 5 commits into from
Jan 31, 2024
Merged

feat: Add planar movement #882

merged 5 commits into from
Jan 31, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Jan 30, 2024

This PR adds assets planar movement.

Screen.Recording.2024-01-30.at.19.15.19.mov

Closes: decentraland/sdk#1068
Fixes: decentraland/sdk#1075

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b0af14
Status: ✅  Deploy successful!
Preview URL: https://1d653669.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-add-plannar-movement.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-plannar-movement/dcl-sdk-7.3.41-7726360572.commit-efd0b69.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-plannar-movement/dcl-sdk-commands-7.3.41-7726360572.commit-efd0b69.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-plannar-movement/@dcl/inspector/dcl-inspector-7.3.41-7726360572.commit-efd0b69.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/add-plannar-movement-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/add-plannar-movement

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (ece036d) 67.29% compared to head (2b0af14) 67.21%.

Files Patch % Lines
...ages/@dcl/inspector/src/lib/babylon/setup/input.ts 8.69% 21 Missing ⚠️
...ctor/src/lib/babylon/decentraland/gizmo-manager.ts 64.86% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   67.29%   67.21%   -0.09%     
==========================================
  Files         517      517              
  Lines       15874    15931      +57     
  Branches     2036     2038       +2     
==========================================
+ Hits        10683    10708      +25     
- Misses       4864     4896      +32     
  Partials      327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyaiox cyaiox merged commit a988b80 into main Jan 31, 2024
9 of 10 checks passed
@cyaiox cyaiox deleted the feat/add-plannar-movement branch January 31, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants