Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onChange for custom componetns #1043

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

gonpombo8
Copy link
Contributor

Forward params to explorer alpha

forward params to explorer alpha
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/onchange-and-forward-params/dcl-sdk-7.6.8-12244313631.commit-9d225c7.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/onchange-and-forward-params/dcl-sdk-commands-7.6.8-12244313631.commit-9d225c7.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/onchange-and-forward-params/@dcl/inspector/dcl-inspector-7.6.8-12244313631.commit-9d225c7.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/onchange-and-forward-params-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/onchange-and-forward-params

Copy link

cloudflare-workers-and-pages bot commented Dec 6, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: f7d4391
Status: ✅  Deploy successful!
Preview URL: https://80f27bc1.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-onchange-and-forward-par.js-sdk-toolchain.pages.dev

View logs

Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gonpombo8 gonpombo8 merged commit 4123b99 into main Dec 10, 2024
8 checks passed
@gonpombo8 gonpombo8 deleted the fix/onchange-and-forward-params branch December 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants