Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow TextShape outline width decimals #1011

Merged
merged 1 commit into from
Sep 25, 2024
Merged

allow TextShape outline width decimals #1011

merged 1 commit into from
Sep 25, 2024

Conversation

nicoecheza
Copy link
Contributor

Copy link

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec13276
Status: ✅  Deploy successful!
Preview URL: https://d444bd01.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-outline-width.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/outline-width/dcl-sdk-7.5.8-11038720482.commit-a0940b7.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/outline-width/dcl-sdk-commands-7.5.8-11038720482.commit-a0940b7.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/outline-width/@dcl/inspector/dcl-inspector-7.5.8-11038720482.commit-a0940b7.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/outline-width-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/outline-width

@nicoecheza nicoecheza enabled auto-merge (squash) September 25, 2024 18:20
@nicoecheza nicoecheza merged commit 7e87395 into main Sep 25, 2024
8 checks passed
@nicoecheza nicoecheza deleted the fix/outline-width branch September 25, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No decimals on Text Outline
2 participants