From a58e6ef3cecbcd2d53d5f89e1d7ced3cab21b366 Mon Sep 17 00:00:00 2001 From: Damien Duhamel Date: Thu, 30 Nov 2017 13:54:40 +0100 Subject: [PATCH 1/2] Fixes backspace remove empty block --- .../Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js b/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js index 9cb1b69e6d32..dd32094360a9 100644 --- a/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js +++ b/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js @@ -54,8 +54,8 @@ const BreakToDefaultBlockOpts = { export const BreakToDefaultBlockConfigured = BreakToDefaultBlock(BreakToDefaultBlockOpts); const BackspaceCloseBlock = (options = {}) => ({ - onKeyDown(e, data, change) { - if (data.key != 'backspace') return; + onKeyDown(data, change) { + if (data.key !== 'Backspace') return; const { defaultBlock = 'paragraph', ignoreIn, onlyIn } = options; const { startBlock } = change.value; From bfb53e8d6083988c36f28dbd412d85257758c960 Mon Sep 17 00:00:00 2001 From: Damien Duhamel Date: Thu, 30 Nov 2017 13:59:16 +0100 Subject: [PATCH 2/2] rename data to event --- .../Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js b/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js index dd32094360a9..34820045b69c 100644 --- a/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js +++ b/src/components/Widgets/Markdown/MarkdownControl/VisualEditor/plugins.js @@ -54,8 +54,8 @@ const BreakToDefaultBlockOpts = { export const BreakToDefaultBlockConfigured = BreakToDefaultBlock(BreakToDefaultBlockOpts); const BackspaceCloseBlock = (options = {}) => ({ - onKeyDown(data, change) { - if (data.key !== 'Backspace') return; + onKeyDown(event, change) { + if (event.key !== 'Backspace') return; const { defaultBlock = 'paragraph', ignoreIn, onlyIn } = options; const { startBlock } = change.value;