Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown widget loses focus on initial entry #901

Closed
erquhart opened this issue Dec 8, 2017 · 4 comments · Fixed by #955
Closed

Markdown widget loses focus on initial entry #901

erquhart opened this issue Dec 8, 2017 · 4 comments · Fixed by #955

Comments

@erquhart
Copy link
Contributor

erquhart commented Dec 8, 2017

- Do you want to request a feature or report a bug?

bug

- What is the current behavior?

The markdown editor uses a debounce for updating it's value in the redux store, about 150ms I believe. The first time this debounce runs, the editor loses focus. So usually just after the first character is typed. Only happens that one time in the session, and only if the editor was initially empty.

- If the current behavior is a bug, please provide the steps to reproduce.

  • Open an entry with an empty markdown widget
  • Start entering text

- What is the expected behavior?

Markdown widget should not lose focus.

- Please mention your CMS, node.js, and operating system version.

CMS 1.0.2

@erquhart
Copy link
Contributor Author

erquhart commented Dec 8, 2017

It's almost certainly due to new logic included with 1.0:

https://github.com/netlify/netlify-cms/blob/master/src/components/EditorWidgets/Markdown/MarkdownControl/VisualEditor/index.js#L52-L58

The purpose of that change was to resolve an issue where the markdown field did not reset it's value if you went directly to a new entry from an existing entry. It now appears that it didn't resolve that problem either.

@erquhart
Copy link
Contributor Author

erquhart commented Jan 5, 2018

Had to revert fix, still an issue.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Oct 29, 2019
@martinjagodic
Copy link
Member

Closing as stale and/or outdated.

@martinjagodic martinjagodic closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants