Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Object widgets #851

Closed
custa1200 opened this issue Nov 29, 2017 · 12 comments
Closed

Collapse Object widgets #851

custa1200 opened this issue Nov 29, 2017 · 12 comments

Comments

@custa1200
Copy link

I am using Object types to organise sections. it would be great if they could be collapsed and expanded, ideally defaults set in the config.yml

@erquhart
Copy link
Contributor

We have collapsible lists and list items in the UI overhaul, collapsing objects wouldn't be a stretch. I don't think we'd put it in the config just yet, but I have considered it for collapsible items in general.

I think after 1.0 we could put this in.

cc/ @neutyp

@t1merickson
Copy link

Dumb question: what is an object as opposed to a widget?

What is the benefit of seeing these collapsed, and what would they show when collapsed?

@tech4him1
Copy link
Contributor

@neutyp An object is one of our widget types, that is simply used to group other widgets together.
capture

@t1merickson
Copy link

t1merickson commented Dec 17, 2017

Aha! Thanks! This should and could easily collapse in the same way that lists do :) Design should be the exact same, without the button at right to add another item

ps. why don't we call an 'Object' a 'Group' 😛

@tech4him1
Copy link
Contributor

tech4him1 commented Dec 17, 2017

@neutyp In most cases, the user should not be able to add an item. @erquhart @Benaiah Is there any reason that we would want an object widget to be user-editable?

@t1merickson
Copy link

FYI, I wasnt implying the ability to re-arrange or delete (which are possible in list widget). I just meant the collapse function can look the exact same

@tech4him1
Copy link
Contributor

Oh, of course, I misread your statement. The term object is what we call a group in JavaScript code, so I guess it just got carried over to the widget name :).

@erquhart
Copy link
Contributor

@drlogout provided a PR for this a while ago, getting it merged now. It does reuse the styling of the list expand/collapse functionality as expected.

@neutyp I do intend at some point to rename "object" to "group", agreed.

@tech4him1
Copy link
Contributor

@erquhart @neutyp What about renaming it to group, but leaving object as a depreciated option?

@erquhart
Copy link
Contributor

erquhart commented Jan 2, 2018

@tech4him1 agreed.

@andreasvirkus
Copy link

Hi there, any action on this? Would love to see collapsed objects.

My reason is that I'm defining every JSON field for a translation file and the nesting is quite heavy.
Collapsed objects/groups would make the navigation a lot more user-friendly.

@erquhart
Copy link
Contributor

Just needs design and elbow grease :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants