fix(i18n): fixes that preview not changing with locale #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though we are passing `onLocaleChange` prop to EditorControlPane, that prop is not actually being used by the component. So EditorLayout doesn't get updates reagrding locale selection changes. This was causing preview pane to not update according to the selected locale as mentioned in issue: decaporg#5337
|
Prop was passed, but was not being used So leftPanelLocale was always undefined and thus previewEntry had data always for default locale only |
erezrokah
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Though we are passing
onLocaleChangeprop to EditorControlPane, that prop is not actually being used by the component.So EditorLayout doesn't get updates reagrding locale selection changes.
This was causing preview pane to not update according to the selected locale as mentioned in issue: #5337
closes #5337
Checklist
yarn format.yarn test.A picture of a cute animal (not mandatory but encouraged)
Red Panda