Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling to avoid case insensitivity issues with image uploads #540

Closed
verythorough opened this issue Aug 18, 2017 · 5 comments
Closed

Comments

@verythorough
Copy link
Contributor

- Do you want to request a feature or report a bug?
A feature to help avoid bugs? 😛

- What is the current behavior?
It's possible to upload images with identical names if taken case-insensitively. For example, IMAGE.jpg and image.jpg can be uploaded without conflict. Of course GitHub is fine with this, as it's case sensitive, but local machines and hosting environments may not be.

- If the current behavior is a bug, please provide the steps to reproduce.
Create or edit a post, and add two different images with file names that only differ by capitalization.

- What is the expected behavior?
I'm not sure how we want to handle this (and of course it certainly changes some with the coming Media Library UI). Perhaps the simplest is when the media library uploader checks for existing files with the same name, we make sure the check is case insensitive, and handle it in the same way as we would when a user tries to upload an identically-named file (append a 1, ask the user to rename or overwrite, whatever).

- Please mention your node.js, and operating system version.
n/a

@tech4him1
Copy link
Contributor

tech4him1 commented Aug 18, 2017

Related to #247 (Images with same filename overwrite old images.).

@erquhart
Copy link
Contributor

Related to #350.

@erquhart
Copy link
Contributor

erquhart commented Dec 8, 2017

Planning to fix in #853.

@tech4him1
Copy link
Contributor

@erquhart Is this fixed now?

@erquhart
Copy link
Contributor

erquhart commented Dec 20, 2017

@tech4him1 good catch, fixed in #853.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants