Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #524

Closed
tech4him1 opened this issue Aug 14, 2017 · 8 comments
Closed

Update Dependencies #524

tech4him1 opened this issue Aug 14, 2017 · 8 comments
Assignees
Milestone

Comments

@tech4him1
Copy link
Contributor

tech4him1 commented Aug 14, 2017

Currently, many of the CMS' dependencies (dev and normal) have updates available (use yarn outdated). We should probably go through them and determine which should be updated, and which should not. This issue will track progress.

Related to #542, #589.

Separate Issues: #478, #413, #664.

@tech4him1
Copy link
Contributor Author

tech4him1 commented Aug 14, 2017

  • The CMS' node-sass version does not support Node v8. SASS is no longer needed with [email protected].
  • autoprefixer should be updated to add/remove browser prefixes.

@erquhart erquhart added this to the 1.0.0 milestone Sep 8, 2017
@tech4him1
Copy link
Contributor Author

tech4him1 commented Sep 9, 2017

React depreciations: prop-types and react-create-class will need to be installed as separate packages.

Done in #590.

@tech4him1
Copy link
Contributor Author

tech4him1 commented Sep 9, 2017

Current Yarn warnings (w/[email protected]):

Also yarn has some peer-dependency errors from yarnpkg/yarn#2688 and yarnpkg/yarn#2387 that we don't need to worry about too much -- so some of the warnings Yarn outputs are not valid. This bug will be fixed in Yarn 1.1.0, see yarnpkg/yarn#4478.

@tech4him1
Copy link
Contributor Author

tech4him1 commented Sep 9, 2017

So for dependency updates, I'm thinking of going through two stages:

  1. Upgrade packages that are currently giving depreciation warnings (or are no longer supported and might break things).
  2. Figure out if we want to upgrade any major versions that are still working (react-router, etc.).

Thoughts?

@erquhart
Copy link
Contributor

@tech4him1 sounds like a plan.

@tech4him1
Copy link
Contributor Author

tech4him1 commented Sep 28, 2017

Dependency updates will be split into three categories:

  1. UI dependencies. (React, Redux, Notifications) These should be really easy to test -- either the UI is broken or it is not.
  2. Dev dependencies. (WebPack, Babel) These are fairly easy to test whether they break something or not, we'll just need to watch the transpiler's output.
  3. Backend/Internal dependencies. (gotrue-js, uuid) These will need fairly intensive testing to make sure that they still work for everybody.

@tech4him1
Copy link
Contributor Author

OK, I think the bulk of this is done. @erquhart @Benaiah are you good with me closing this?

@erquhart
Copy link
Contributor

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants