Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/browser throws when used in electron preload scripts #303

Closed
Pupix opened this issue Sep 7, 2016 · 1 comment
Closed

debug/browser throws when used in electron preload scripts #303

Pupix opened this issue Sep 7, 2016 · 1 comment
Labels
has-pr This issue has an accompanying pull request

Comments

@Pupix
Copy link

Pupix commented Sep 7, 2016

As the title says, when logging, the debug/browser file checks here for WebkitAppearance in document.documentElement.style , but at that time in the page's lifecycle documentElement is not yet defined and I get this
TypeError: Cannot read property 'style' of null.

Guess there could be a check for chromium based apps, where if both document and process exist, you are good to go.

Cheers,
Pupix
This was referenced Sep 27, 2016
Closed
Merged
Closed
@thebigredgeek
Copy link
Contributor

I believe this was fixed here. Closing

@thebigredgeek thebigredgeek added the has-pr This issue has an accompanying pull request label Nov 14, 2016
@fab1an fab1an mentioned this issue Apr 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-pr This issue has an accompanying pull request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thebigredgeek @Pupix