-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New telemetry handler for phoenix 1.5+ projects #17
Comments
Yes, I would gladly accept contribution |
Would love to see this released in some form. Not the maintainer, but a major version bump with some notes on which version of the package is compatible with which version of Phoenix Framework should be enough? |
yes of course that would be enough |
@nurugger07 are you still working on this? I would love to see your changes merged into this library as well. |
@nurugger07 maybe we can help you somehow? |
FWIW, @nurugger07's repo works well in production so far and it's likely the adjustments just need to be copied over if he's preoccupied. |
Sorry, things have been a bit crazy lately but I'll get this wrapped up this week |
Got a WIP PR up so that @deadtrickster could begin the review process. Still need to update docs and add some additional functionality |
@nurugger07 looking at your implementation for some of our use cases, what help is required to get this merged in? |
@nurugger07 i am also waiting for this change |
Greetings @deadtrickster!
I hope all is well. I have created a project called
prometheus-phx
that handles the telemetry changes in phoenix 1.5. I would be happy to contribute those changes back to this project but they would be breaking changes and require a major version bump. I'm not sure what your preference would be moving forward. Do you still want to continue maintaining this project? Would you want to transfer the project? Looking forward to hearing from you :)For those interested here is a link to the new project: https://github.com/theblitzapp/prometheus-phx
It's not a hex package yet because I'm waiting the preferred direction from deadtrickster
The text was updated successfully, but these errors were encountered: