Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument new idle_time metric introduced on ecto_sql 3.3.0 #26

Open
GPrimola opened this issue Oct 30, 2020 · 1 comment · May be fixed by #28
Open

Instrument new idle_time metric introduced on ecto_sql 3.3.0 #26

GPrimola opened this issue Oct 30, 2020 · 1 comment · May be fixed by #28

Comments

@GPrimola
Copy link

ecto_sql v3.3.0 introduced a new metric idle_time that measure the time the connection spent waiting before being checked out for the query

@ackerdev
Copy link

@GPrimola I've implemented this along with a few other changes in a fork here: https://github.com/theblitzapp/prometheus-ecto/tree/idle-and-repo-labels

Check the PR linked above to see what else is changed; there are some breaking changes. The idle_time changes are in a single commit, so if you want to avoid the breaking changes it should be simple to set up your own fork and cherry-pick my commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants