Skip to content

Commit

Permalink
percpu-add-preemption-checks-to-__this_cpu-ops-fix-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: storage class should be at the beginning of the declaration
torvalds#25: FILE: lib/smp_processor_id.c:10:
+notrace static unsigned int check_preemption_disabled(const char *what1,

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
torvalds#36: FILE: lib/smp_processor_id.c:42:
+	printk(KERN_ERR "BUG: using %s%s() in preemptible [%08x] code: %s/%d\n",

ERROR: space required after that ',' (ctx:VxV)
torvalds#46: FILE: lib/smp_processor_id.c:56:
+	return check_preemption_disabled("smp_processor_id","");
 	                                                   ^

total: 1 errors, 2 warnings, 36 lines checked

./patches/percpu-add-preemption-checks-to-__this_cpu-ops-fix.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Christoph Lameter <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and hnaz committed Mar 22, 2014
1 parent d4d6851 commit 709687f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/smp_processor_id.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ notrace static unsigned int check_preemption_disabled(const char *what1,

notrace unsigned int debug_smp_processor_id(void)
{
return check_preemption_disabled("smp_processor_id","");
return check_preemption_disabled("smp_processor_id", "");
}
EXPORT_SYMBOL(debug_smp_processor_id);

Expand Down

0 comments on commit 709687f

Please sign in to comment.