Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add previous attribute #753

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jonbirke0927
Copy link

No description provided.

@ddnexus
Copy link
Owner

ddnexus commented Dec 5, 2024

@jonbirke0927 This is very interesting! Thank you!

FYI: I am currently and heavily refactoring the keyset, which will support also most UI features like pagination with numeric pages which enable the use of regular pagy_nav helpers with keyset pagination.

Your changes are easily portable to the new refactored code.

It's currently working quite well, however there are still no tests nor docs (just comments in the code). You can take a look at the keyset-cached branch for details.

@jonbirke0927
Copy link
Author

@jonbirke0927 This is very interesting! Thank you!

FYI: I am currently and heavily refactoring the keyset, which will support also most UI features like pagination with numeric pages which enable the use of regular pagy_nav helpers with keyset pagination.

Your changes are easily portable to the new refactored code.

It's currently working quite well, however there are still no tests nor docs (just comments in the code). You can take a look at the keyset-cached branch for details.

Awesome! Cool to see you're working on some changes. Will be able to take a look tomorrow. Excited to see the new functionality and enjoying using the gem so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants