diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index c8dc9930f..e4cc7f5ea 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -2,14 +2,21 @@ Pull Requests are welcome! -Here are a few useul information for you: +Here are a few useful information for contributors: 1. If you are planning for a complex PR, we suggest that you check before hand whether your proposed changes are going to be accepted by posting your ideas in the [Feature Requests](https://github.com/ddnexus/pagy/discussions/categories/feature-requests) discussion area 2. For adding translations of locale dictionary files please follow the [locales readme instructions here](https://github.com/ddnexus/pagy/blob/master/gem/locales/README.md). -3. **Development** +3. **Pagy repo setup** + - Clone pagy: `git clone https://github.com/ddnexus/pagy && cd pagy` + - Install the gems: `bundle install` + - Install node if not present... + - Optional: install pnpm. It's better if you use corepack to get the right version from package.json + ([instructions](https://pnpm.io/installation#using-corepack)) + - Install modules: `npm install` (or `pnpm install`) +4. **Development** - Please create your own branch out of `master` and use it for you development and PR - Ensure you are basing your PR on the `master` branch and keep rebasing it on `master` when it changes - **Code** @@ -18,7 +25,7 @@ Here are a few useul information for you: with the [Pagy::Console](https://ddnexus.github.io/pagy/docs/api/console/) directly from the repo - **Docs** - `cd` in the pagy root directory - - Run `npm -i` or (`pnpm -i` if pnpm is installed). + - Run `npm install` or (`pnpm install` if pnpm is installed). - Run `retype start` - Point your browser at `http://localhost:5000/pagy` for real-time feedback 5. **Testing** diff --git a/.github/ISSUE_TEMPLATE/Code.yml b/.github/ISSUE_TEMPLATE/Code.yml index 131d6d894..65e767f26 100644 --- a/.github/ISSUE_TEMPLATE/Code.yml +++ b/.github/ISSUE_TEMPLATE/Code.yml @@ -19,7 +19,7 @@ body: attributes: label: 👀 Before submitting... options: - - label: I upgraded to pagy version 8.4.0 + - label: I upgraded to pagy version 8.4.1 required: true - label: I searched through the [Documentation](https://ddnexus.github.io/pagy/) required: true diff --git a/.github/latest_release_body.md b/.github/latest_release_body.md index 6ac7875d6..df3eb2cb2 100644 --- a/.github/latest_release_body.md +++ b/.github/latest_release_body.md @@ -8,13 +8,12 @@ the [details](https://github.com/ddnexus/pagy/discussions/672#discussioncomment-9212328)) - See the [CHANGELOG](https://ddnexus.github.io/pagy/changelog) for possible breaking changes -### Changes in 8.4.0 +### Changes in 8.4.1 -- Retrieve only @in items: - - improve the performance of the last page in - particular storage conditions (see #696) -- Improve pagy launcher for pagy devs +- Fix pagy.in in pagy_get_items method introduced in 8.4.0 (see #696) (closes #704) (closes #708) (#707) +- Fix renamed Frontend Helpers to JS Tools and typo `next_a` "aria-label" (#700) +- Fix rubocop [CHANGELOG](https://ddnexus.github.io/pagy/changelog) diff --git a/.idea/runConfigurations/Calendar.xml b/.idea/runConfigurations/Calendar.xml index 85de4ab93..3b8d997c0 100644 --- a/.idea/runConfigurations/Calendar.xml +++ b/.idea/runConfigurations/Calendar.xml @@ -8,11 +8,7 @@ - - - - - +