Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep alive step failed if the branch is protected #25

Closed
julienloizelet opened this issue Jan 16, 2024 · 4 comments
Closed

Keep alive step failed if the branch is protected #25

julienloizelet opened this issue Jan 16, 2024 · 4 comments

Comments

@julienloizelet
Copy link
Collaborator

julienloizelet commented Jan 16, 2024

Since the 1.2.0 release of the gautamkrishnar/keepalive-workflow, the "keep alive" step failed if the branch is protected (which is a common practice, I guess), even if we set the permission: write directive.

I opened an issue for this: gautamkrishnar/keepalive-workflow#20

As a workaround, I think we could always pass the new auto_write_check to false.

@tyler36
Copy link

tyler36 commented Jan 16, 2024

Just got notified that "ddev-browser" stable test failed; seems to be this.

@tyler36
Copy link

tyler36 commented Jan 16, 2024

auto_write_check changed here, should flow to all the addons that use this, right?

@julienloizelet
Copy link
Collaborator Author

The keep alive action has been fixed with a new 1.2.2 release.

Default value of the new auto_write_check has been changed to false to avoid breaking change.

Thus, it should work again (worked for me) and we don't have to change anything.

@tyler36
Copy link

tyler36 commented Jan 16, 2024

Confirmed. ddev-browsersync now working.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants