From 6689bc50a675c56814b1039cc1d5caee9ee88352 Mon Sep 17 00:00:00 2001 From: d3fault Date: Sun, 3 Oct 2021 13:03:53 -0700 Subject: [PATCH] add clarification of what legal effect --signoff is supposed to even have Fix: #106 Signed-off-by: d3fault --- index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.js b/index.js index fad9f7c..119ceef 100644 --- a/index.js +++ b/index.js @@ -168,9 +168,9 @@ module.exports = ({ app }) => { } function handleOneCommit (pr, dcoFailed) { - return `You only have one commit incorrectly signed off! To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit commit --amend --no-edit --signoff\n\`\`\`\nNow your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\`` + return `You only have one commit incorrectly signed off! Signing off the commit certifies that the committer has the rights to submit this work under the project's license and agrees to the [Developer Certificate of Origin](https://developercertificate.org), either version 1.1 of the Developer Certificate of Origin, or (at your option) any later version. To sign off, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit commit --amend --no-edit --signoff\n\`\`\`\nNow your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\`` } function handleMultipleCommits (pr, commitLength, dcoFailed) { - return `You have ${dcoFailed.length} commits incorrectly signed off. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit rebase HEAD~${commitLength} --signoff\n\`\`\`\n Now your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\`` + return `You have ${dcoFailed.length} commits incorrectly signed off. Signing off the commit certifies that the committer has the rights to submit this work under the project's license and agrees to the [Developer Certificate of Origin](https://developercertificate.org), either version 1.1 of the Developer Certificate of Origin, or (at your option) any later version. To sign off, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit rebase HEAD~${commitLength} --signoff\n\`\`\`\n Now your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\`` }