Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Broken running status #117

Open
benlubas opened this issue Oct 11, 2023 · 0 comments
Open

[Bug] Broken running status #117

benlubas opened this issue Oct 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@benlubas
Copy link

benlubas commented Oct 11, 2023

#69 broke the "running" status

@usmcamp0811 I have some questions about this PR that you submitted

here you set self.external_kernel to true in both cases, and then you gate the "running" status update behind not self.external_kernel here. This just completely disables the running status functionality.

I'm assuming that in this case if ".json" not in self.kernel_name: it's supposed to set external kernel to false, and that line is just a typo. But I'm also wondering why the status updates needed to be disabled with external kernels at all?

I'll note for completeness that this also removes magma's ability to shut down a running kernel on deinit. as seen here

@benlubas benlubas added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant