Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove renderlet from example and test code #906

Closed
gordonwoodhull opened this issue Apr 6, 2015 · 0 comments
Closed

remove renderlet from example and test code #906

gordonwoodhull opened this issue Apr 6, 2015 · 0 comments
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

If we've deprecated it, we shouldn't use it ourselves.

grodo:dc.js gordon$ grep -r --exclude=*.min.* --exclude=dc.js "renderlet(" .
...
./spec/bar-chart-spec.js:                        .renderlet(function(_chart) {
./spec/base-mixin-spec.js:            chart.renderlet(firstRenderlet);
./spec/base-mixin-spec.js:            chart.renderlet(secondRenderlet);
./spec/bubble-chart-spec.js:            chart.renderlet(renderlet);
./spec/composite-chart-spec.js:            chart.children()[0].renderlet(function(chart) {
./spec/coordinate-grid-chart-spec.js:                chart.renderlet(function (chart) {
./spec/core-spec.js:            dc.renderlet(function(group) {
./spec/data-grid-spec.js:            chart.renderlet(derlet);
./spec/data-table-spec.js:            chart.renderlet(derlet);
./spec/helpers/spec-helper.js:    dc.renderlet(null);
./spec/pie-chart-spec.js:            chart.renderlet(function() {
./src/base-mixin.js:    #### .renderlet(renderletFunction)
./src/base-mixin.js:    chart.renderlet(function(chart){
./src/base-mixin.js:    deprecated `.renderlet()` method.
./src/coordinate-grid-mixin.js:    chart.renderlet(function(chart){
./src/core.js:        dc._renderlet(group);
./src/core.js:        dc._renderlet(group);
./src/events.js:    chart.renderlet(function(chart){
...
./web/ep/index.html:    .renderlet(function (chart) {
./web/ep/index.html:    .renderlet(function (chart) {
./web/ep/index.html:    .renderlet(function (grid) {
./web/ep/list.js:  .renderlet(function (chart) {
./web/ep/list.js:        .renderlet(function (table) {
./web/examples/bar.html:    .renderlet(function(chart) {
./web/play-ground.html:        .renderlet(function (chart) {
./web/play-ground.html:        .renderlet(function (chart) {
./web/stock.js:        .renderlet(function (table) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant