-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM Dependecy Upgrades #844
Conversation
This is great. However, running the tests in the browser, where I think I was seeing hanging with jasmine 2.* before, shows that 9 of our tests are not actually functioning. (I'm not sure why they aren't color coded on the command line.) For example, the throttle test in event-spec.js is missing
after the test, to make it function, and some of the tests in the line-chart-spec.js apparently are selecting nothing and thus expecting nothing. I'm fine to check this in without it, but perhaps you'd like to take a look. |
The last non-functioning test is kind of amusing:
|
Wow, that is incredibly hard to notice. That yellow color is almost the same as the green! |
Yeah, looks like somebody mouse cut/drag/pasted it in the wrong place. |
looks like that somebody was me, when i was porting the last of the tests from vows. :-( glad that jasmine now detects tests without any expectations! |
:P I've fixed that one. Looking into the others. |
Line chart's don't render dots if |
Should that test should set brushOn(false)? |
Correct. mtraynham@c0c724c#diff-282e46010240734464c30e3d548e44baR38 I think it's good to go. All of them should be working properly now. |
Just to be sure, and to enjoy how much faster the tests run after #825, I ran the tests on 5 browsers on 3 OS's. Looks great. Rebased to master and will push as 2.0.0-beta.5. |
merged (hmm, gitflow doesn't always seem to maintain the commit messages that make closing PRs automatic) |
Which branch did that make it into? Don't see that commit any where. |
Ahh, it seems the merge from master -> develop didn't pick up the |
Sorry about that! So used to that conflict that I was careless. Fixed now. |
I went ahead and upgraded all dependencies to their latest releases. The only thing that gave me an issue was
jscs
which I kind of expected (0.6 -> 1.2). All of the grunt tasks and tests seem to work correctly. Interested to see how the sauce-labs build goes.Edit Oh, added the Gemnasium badge. It's a nice to have, but warns of out-dated dependencies.