Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Dependecy Upgrades #844

Closed
wants to merge 4 commits into from
Closed

Conversation

mtraynham
Copy link
Contributor

I went ahead and upgraded all dependencies to their latest releases. The only thing that gave me an issue was jscs which I kind of expected (0.6 -> 1.2). All of the grunt tasks and tests seem to work correctly. Interested to see how the sauce-labs build goes.

Edit Oh, added the Gemnasium badge. It's a nice to have, but warns of out-dated dependencies.

@gordonwoodhull
Copy link
Contributor

This is great. However, running the tests in the browser, where I think I was seeing hanging with jasmine 2.* before, shows that 9 of our tests are not actually functioning. (I'm not sure why they aren't color coded on the command line.)

For example, the throttle test in event-spec.js is missing

            jasmine.clock().tick(100);

after the test, to make it function, and some of the tests in the line-chart-spec.js apparently are selecting nothing and thus expecting nothing.

I'm fine to check this in without it, but perhaps you'd like to take a look.

@gordonwoodhull
Copy link
Contributor

The last non-functioning test is kind of amusing:

        it('print simple string and a range', function() {
            expect(printer(["a", [10, 30]]), "a).toEqual([10 -> 30]");
        });

@mtraynham
Copy link
Contributor Author

Wow, that is incredibly hard to notice. That yellow color is almost the same as the green!

@mtraynham
Copy link
Contributor Author

Yeah, looks like somebody mouse cut/drag/pasted it in the wrong place.

@gordonwoodhull
Copy link
Contributor

looks like that somebody was me, when i was porting the last of the tests from vows. :-(

glad that jasmine now detects tests without any expectations!

@mtraynham
Copy link
Contributor Author

:P I've fixed that one. Looking into the others.

@mtraynham
Copy link
Contributor Author

Line chart's don't render dots if brushOn is true. Still need to fix the event issue, looks a bit more involved though.

@gordonwoodhull
Copy link
Contributor

Should that test should set brushOn(false)?

@mtraynham
Copy link
Contributor Author

Correct. mtraynham@c0c724c#diff-282e46010240734464c30e3d548e44baR38

I think it's good to go. All of them should be working properly now.

@gordonwoodhull
Copy link
Contributor

Just to be sure, and to enjoy how much faster the tests run after #825, I ran the tests on 5 browsers on 3 OS's. Looks great. Rebased to master and will push as 2.0.0-beta.5.

@gordonwoodhull
Copy link
Contributor

merged

(hmm, gitflow doesn't always seem to maintain the commit messages that make closing PRs automatic)

@mtraynham mtraynham deleted the dependecy_upgrades branch January 26, 2015 15:00
@mtraynham mtraynham restored the dependecy_upgrades branch January 26, 2015 15:08
@mtraynham
Copy link
Contributor Author

Which branch did that make it into? Don't see that commit any where.

@mtraynham
Copy link
Contributor Author

Ahh, it seems the merge from master -> develop didn't pick up the package.json changes.

@mtraynham mtraynham deleted the dependecy_upgrades branch January 26, 2015 15:13
@gordonwoodhull
Copy link
Contributor

Sorry about that! So used to that conflict that I was careless. Fixed now.

@mtraynham mtraynham mentioned this pull request Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants