[#49] introduce colspan to data table group cell

dc-js · Sep 6, 2012 · 23632af · 23632af
1 parent dc6391e
commit 23632af
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/dc.js b/dc.js
@@ -2140,6 +2140,7 @@ dc.dataTable = function(parent, chartGroup) {
             .attr("class", "group")
                 .append("td")
                 .attr("class", "label")
+                .attr("colspan", _columns.length)
                 .text(function(d) {
                     return _chart.keyAccessor()(d);
                 });

diff --git a/dc.min.js b/dc.min.js
diff --git a/src/data-table.js b/src/data-table.js
@@ -32,6 +32,7 @@ dc.dataTable = function(parent, chartGroup) {
             .attr("class", "group")
                 .append("td")
                 .attr("class", "label")
+                .attr("colspan", _columns.length)
                 .text(function(d) {
                     return _chart.keyAccessor()(d);
                 });

diff --git a/test/data-table-test.js b/test/data-table-test.js
@@ -46,6 +46,9 @@ suite.addBatch({
         'order should be set':function(chart) {
             assert.equal(chart.order(), d3.ascending);
         },
+        'should have column span set on group tr':function(chart) {
+            assert.equal(chart.selectAll("tr.group td")[0][0].getAttribute("colspan"), "2");
+        },
         'should have id column created':function(chart) {
             assert.equal(chart.selectAll("td.0")[0][0].innerHTML, 8);
             assert.equal(chart.selectAll("td.0")[0][1].innerHTML, 3);