Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyodbc docker file #107

Closed
JCZuurmond opened this issue Feb 15, 2021 · 1 comment · Fixed by #122
Closed

Remove pyodbc docker file #107

JCZuurmond opened this issue Feb 15, 2021 · 1 comment · Fixed by #122

Comments

@JCZuurmond
Copy link
Contributor

Currently there is a docker file which installs the ODBC driver for Microsoft SQL server. The container created from the docker file is used in the Circle CI, only. This container/file is not needed if the ODBC driver is installed in a CircleCI (build) job.

  • this docker file/container is redundant since we have circleci
  • changing the docker container is cumbersome, since the publishing is not automated.
    The docker file also install the requirements.txt which is causing version problems and the requirements.txt does not exists if PR Clean up tox ini #105 is merged.
@JCZuurmond
Copy link
Contributor Author

I think it would make sense to make a build stage like here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant