From 83f926898c68dec9d096ebf6a3632a4b7d398741 Mon Sep 17 00:00:00 2001 From: Jeremy Cohen Date: Wed, 6 Jan 2021 19:48:13 +0100 Subject: [PATCH 1/2] Backwards + frontwards compatible --- .../materializations/insert_by_period_materialization.sql | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/macros/materializations/insert_by_period_materialization.sql b/macros/materializations/insert_by_period_materialization.sql index 26ce2840..5ca4da73 100644 --- a/macros/materializations/insert_by_period_materialization.sql +++ b/macros/materializations/insert_by_period_materialization.sql @@ -143,8 +143,12 @@ ); {%- endcall %} {% set result = load_result('main-' ~ i) %} - {% set rows_inserted = result['response']['rows_affected'] %} + {% if 'response' in result.keys() %} {# added in v0.19.0 #} + {% set rows_inserted = result['response']['rows_affected'] %} + {% else %} {# older versions #} + {% set rows_inserted = result['status'].split(" ")[2] | int %} {% endif %} + {%- set sum_rows_inserted = loop_vars['sum_rows_inserted'] + rows_inserted -%} {%- if loop_vars.update({'sum_rows_inserted': sum_rows_inserted}) %} {% endif -%} @@ -167,7 +171,7 @@ {%- set status_string = "INSERT " ~ loop_vars['sum_rows_inserted'] -%} - {% call noop_statement(name='main', message=status_string) -%} + {% call noop_statement('main', status_string) -%} -- no-op {%- endcall %} From 8e0624626d0f3b5f680581ceefd8464fe0417e80 Mon Sep 17 00:00:00 2001 From: Jeremy Cohen Date: Wed, 6 Jan 2021 19:49:38 +0100 Subject: [PATCH 2/2] Add full-refresh step for insert_by_period --- run_test.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/run_test.sh b/run_test.sh index 85b7f3ad..80089ebf 100755 --- a/run_test.sh +++ b/run_test.sh @@ -24,5 +24,8 @@ if [[ ! -z $3 ]]; then _seeds="--select $3 --full-refresh"; fi dbt deps --target $1 dbt seed --target $1 $_seeds +if [ $1 == 'redshift' ]; then + dbt run -x -m test_insert_by_period --full-refresh --target redshift +fi dbt run -x --target $1 $_models dbt test -x --target $1 $_models