-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update used gh actions ahead of set-output, node12 deprecation #580
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
We do need to update bot-changelog.yml
as well but it's actually on me to make an update to the action we reference there to remove the deprecations. This will be true of all the core + adapter repos. I'll get that update done in the next few days and circle back to you.
kind: Under the Hood | ||
body: Update version of used Github Actions | ||
time: 2023-04-26T14:09:30.604603-05:00 | ||
custom: | ||
Author: davidbloss | ||
Issue: "577" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this and then add the Skip Changelog
label to the PR. Since these changes have 0 effect on end users, we don't need a changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll submit a separate PR for the changie_bot workflow.
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]>
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/release-branch-tests.yml
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/main.yml # .github/workflows/release-branch-tests.yml
* update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]>
* more github deprecations fixes (#607) * more github deprecations fixes * swap out abandonded action * update used gh actions ahead of set-output, node12 deprecation (#580) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> --------- Co-authored-by: David Bloss <[email protected]> Co-authored-by: Neelesh Salian <[email protected]>
* more github deprecations fixes (#607) * more github deprecations fixes * swap out abandonded action # Conflicts: # .github/workflows/triage-labels.yml * update used gh actions ahead of set-output, node12 deprecation (#580) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/release-branch-tests.yml * Revert "more github deprecations fixes (#607)" This reverts commit 52fc588. * revert --------- Co-authored-by: David Bloss <[email protected]>
* more github deprecations fixes (#607) * more github deprecations fixes * swap out abandonded action # Conflicts: # .github/workflows/triage-labels.yml * update used gh actions ahead of set-output, node12 deprecation (#580) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml * Revert "more github deprecations fixes (#607)" This reverts commit 27ca3ff. --------- Co-authored-by: David Bloss <[email protected]>
…#612) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/release-branch-tests.yml Co-authored-by: David Bloss <[email protected]>
…#614) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: Neelesh Salian <[email protected]> # Conflicts: # .github/workflows/main-branch-tests.yml # .github/workflows/main.yml # .github/workflows/release-branch-tests.yml Co-authored-by: David Bloss <[email protected]>
…#613) * update used gh actions ahead of set-output, node12 deprecation * add changie log * remove unneeded changelog * Fix for changie that pointed to spark (#584) --------- Co-authored-by: David Bloss <[email protected]> Co-authored-by: Neelesh Salian <[email protected]>
resolves #577 ADAP-485
Description
Update versions of used Github Actions ahead of:
node12 deprecation (Summer 2023)
set-output deprecation fully disabled on 31st May 2023)
Checklist
changie new
to create a changelog entry