Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update used gh actions ahead of set-output, node12 deprecation #580

Merged
merged 5 commits into from
May 5, 2023

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Apr 26, 2023

resolves #577 ADAP-485

Description

Update versions of used Github Actions ahead of:

node12 deprecation (Summer 2023)
set-output deprecation fully disabled on 31st May 2023)

Checklist

@davidbloss davidbloss requested review from emmyoop, a team and VersusFacit April 26, 2023 19:08
@cla-bot cla-bot bot added the cla:yes label Apr 26, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

We do need to update bot-changelog.yml as well but it's actually on me to make an update to the action we reference there to remove the deprecations. This will be true of all the core + adapter repos. I'll get that update done in the next few days and circle back to you.

Comment on lines 1 to 6
kind: Under the Hood
body: Update version of used Github Actions
time: 2023-04-26T14:09:30.604603-05:00
custom:
Author: davidbloss
Issue: "577"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this and then add the Skip Changelog label to the PR. Since these changes have 0 effect on end users, we don't need a changelog.

@davidbloss davidbloss added the Skip Changelog Skips GHA to check for changelog file label Apr 26, 2023
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll submit a separate PR for the changie_bot workflow.

@davidbloss davidbloss merged commit a2c40f0 into main May 5, 2023
@davidbloss davidbloss deleted the ADAP-485/update-used-gh-actions-versions branch May 5, 2023 19:00
emmyoop pushed a commit that referenced this pull request May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
emmyoop pushed a commit that referenced this pull request May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/release-branch-tests.yml
emmyoop pushed a commit that referenced this pull request May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/main-branch-tests.yml
#	.github/workflows/release-branch-tests.yml
emmyoop pushed a commit that referenced this pull request May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/main-branch-tests.yml
#	.github/workflows/release-branch-tests.yml
emmyoop pushed a commit that referenced this pull request May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/main-branch-tests.yml
#	.github/workflows/main.yml
#	.github/workflows/release-branch-tests.yml
emmyoop pushed a commit that referenced this pull request May 15, 2023
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
emmyoop added a commit that referenced this pull request May 15, 2023
emmyoop added a commit that referenced this pull request May 16, 2023
* more github deprecations fixes (#607)

* more github deprecations fixes

* swap out abandonded action

* update used gh actions ahead of set-output, node12 deprecation (#580)

* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>

---------

Co-authored-by: David Bloss <[email protected]>
Co-authored-by: Neelesh Salian <[email protected]>
emmyoop added a commit that referenced this pull request May 16, 2023
* more github deprecations fixes (#607)

* more github deprecations fixes

* swap out abandonded action
# Conflicts:
#	.github/workflows/triage-labels.yml

* update used gh actions ahead of set-output, node12 deprecation (#580)

* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/release-branch-tests.yml

* Revert "more github deprecations fixes (#607)"

This reverts commit 52fc588.

* revert

---------

Co-authored-by: David Bloss <[email protected]>
emmyoop added a commit that referenced this pull request May 16, 2023
* more github deprecations fixes (#607)

* more github deprecations fixes

* swap out abandonded action
# Conflicts:
#	.github/workflows/triage-labels.yml

* update used gh actions ahead of set-output, node12 deprecation (#580)

* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/main-branch-tests.yml
#	.github/workflows/release-branch-tests.yml

* Revert "more github deprecations fixes (#607)"

This reverts commit 27ca3ff.

---------

Co-authored-by: David Bloss <[email protected]>
emmyoop added a commit that referenced this pull request May 16, 2023
…#612)

* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/main-branch-tests.yml
#	.github/workflows/release-branch-tests.yml

Co-authored-by: David Bloss <[email protected]>
emmyoop added a commit that referenced this pull request May 16, 2023
…#614)

* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
# Conflicts:
#	.github/workflows/main-branch-tests.yml
#	.github/workflows/main.yml
#	.github/workflows/release-branch-tests.yml

Co-authored-by: David Bloss <[email protected]>
nathaniel-may pushed a commit that referenced this pull request May 16, 2023
…#613)

* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: David Bloss <[email protected]>
Co-authored-by: Neelesh Salian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-485] replace all instances of set-output and node16
4 participants