Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-893] [CT-796] [Feature] enable query tagging for dbt tests on snowflake #211

Closed
1 task done
matt-winkler opened this issue Jun 30, 2022 · 2 comments · Fixed by #210
Closed
1 task done

[CT-893] [CT-796] [Feature] enable query tagging for dbt tests on snowflake #211

matt-winkler opened this issue Jun 30, 2022 · 2 comments · Fixed by #210
Labels
enhancement New feature or request good_first_issue Good for newcomers

Comments

@matt-winkler
Copy link
Contributor

Is this your first time opening an issue?

Describe the Feature

query tagging is supported on models and snapshots in snowflake projects, but not on tests. Since tests also run queries against the warehouse, enabling tagging will allow users to have a fuller picture of dbt driven workloads.

Describe alternatives you've considered

  • pre / post hooks to set markers for test runs
  • reliance on user / environment naming conventions to separate workload data

Who will this benefit?

dbt + snowflake users

Are you interested in contributing this feature?

yes

Anything else?

here is how we manage this for snapshots.

@matt-winkler matt-winkler added enhancement New feature or request triage labels Jun 30, 2022
@github-actions github-actions bot changed the title [Feature] enable query tagging for dbt tests on snowflake [CT-796] [Feature] enable query tagging for dbt tests on snowflake Jun 30, 2022
@jameszhenginsta
Copy link

jameszhenginsta commented Jun 30, 2022

Hi,
My company is using DBT and planning to write data quality tests against Snowflake using dbt test. We have jobs that calculate the cost per query and attribute the cost appropriately. However, they have to be tagged. The tests are like any query and can run for very long so it is important to be able to tag and attribute the costs of test.

Thanks!

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 5, 2022

@matt-winkler Thanks for opening! The request feels totally reasonable, as does the implementation you've suggested: "wrapping" the default 'test' materialization, same as we do for seeds and snapshots.

@jtcohen6 jtcohen6 added good_first_issue Good for newcomers and removed triage labels Jul 5, 2022
@jtcohen6 jtcohen6 transferred this issue from dbt-labs/dbt-core Jul 23, 2022
@github-actions github-actions bot changed the title [CT-796] [Feature] enable query tagging for dbt tests on snowflake [CT-893] [CT-796] [Feature] enable query tagging for dbt tests on snowflake Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants