Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-348] Unit tests broken for release branches #77

Closed
leahwicz opened this issue Mar 10, 2022 · 0 comments · Fixed by #80
Closed

[CT-348] Unit tests broken for release branches #77

leahwicz opened this issue Mar 10, 2022 · 0 comments · Fixed by #80
Assignees

Comments

@leahwicz
Copy link
Contributor

For our unit tests, we wanted to make sure we were testing new changes against the newest version of dbt-core so that we could adapt to any changes made there (they are essentially our foundation). So for pushes, PR's, and just manual triggers, we clone the latest code from dbt-core and dbt-postgres on the main branch and use that to test against. The code for this can be found here.

This works well for dbt-redshift when we are testing out the main branch or changes going in to the main branch.

This doesn't work well when we are trying to test a release branch or changes going into a release branch. We would essentially be testing dbt-core code in main against dbt-redshift code that is for 1.0.latest. We should be testing against dbt-core's 1.0.latest branch instead.

We now have breaking changes on the dbt-core main branch that we incorporated into the dbt-redshift main branch but the dbt-redshift 1.0.latest branch is broken because it is referring to the newer dbt-core core.

@github-actions github-actions bot changed the title Unit tests broken for release branches [CT-348] Unit tests broken for release branches Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants