Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-623] [Regression] ensure proper escaping dollar-quoted string literals #492

Closed
2 tasks done
dataders opened this issue Jun 14, 2023 · 0 comments · Fixed by #493
Closed
2 tasks done

[ADAP-623] [Regression] ensure proper escaping dollar-quoted string literals #492

dataders opened this issue Jun 14, 2023 · 0 comments · Fixed by #493
Labels
bug Something isn't working regression

Comments

@dataders
Copy link
Contributor

dataders commented Jun 14, 2023 •
edited
Loading

Is this a regression in a recent version of dbt-redshift?

  • I believe this is a regression in dbt-redshift functionality
  • I have searched the existing issues, and I could not find an existing issue for this regression

while #441 was mostly resolved by #466, the underlying driver of this adapter, redshift_connector was patched to address this same issue in aws/amazon-redshift-python-driver@df7fc1d which was released as version 2.0.911.

to guarantee that all users of dbt-redshift 1.5.latest and onwards make use of this fix, we should update the minimum required version of redshift_connector to match this new release: 2.0.911.
@dataders dataders added bug Something isn't working triage regression labels Jun 14, 2023
@github-actions github-actions bot changed the title [Regression] ensure proper escaping dollar-quoted string literals [ADAP-623] [Regression] ensure proper escaping dollar-quoted string literals Jun 14, 2023
@dataders dataders mentioned this issue Jun 14, 2023
Merged
6 tasks
@jtcohen6 jtcohen6 removed the triage label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase minimum required version of redshift_connector driver dbt-labs/dbt-redshift
2 participants
@dataders @jtcohen6