[CT-1941] [Feature] Stand-alone Python module for RedshiftColumn

[dbeatty10]

See also: dbt-labs/dbt-core#6772

Is this your first time submitting a feature request?

• I have read the expectations for open source contributors
• I have searched the existing issues, and I could not find an existing issue for this feature
• I am requesting a straightforward extension of existing dbt-redshift functionality, rather than a Big Idea better suited to a discussion

Describe the feature

There is a stand-alone {adapter}/column.py module almost everywhere:

• https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/adapters/base/column.py
• https://github.com/dbt-labs/dbt-bigquery/blob/main/dbt/adapters/bigquery/column.py
• https://github.com/dbt-labs/dbt-spark/blob/main/dbt/adapters/spark/column.py
• https://github.com/dbt-labs/dbt-snowflake/blob/main/dbt/adapters/snowflake/column.py

The two exceptions are:

• dbt-core/plugins/postgres/dbt/adapters/postgres/relation.py
• dbt-redshift/dbt/adapters/redshift/relation.py

It's easy enough to standardize on the convention by splitting RedshiftColumn into its own file.

Describe alternatives you've considered

It won't affect the functionality of the dbt-redshift adapter if it stays as-is. But it also won't affect the functionality if it is moved.

Who will this benefit?

It is easier to find the definition or compare definitions across adapters if things are in the standard locations. This is helpful for anyone inspecting the code, including adapter maintainers outside of dbt-postgres that want to compare/contrast implementation details.

It will also allow for slightly more standardization of this file:

dbt-redshift/dbt/adapters/redshift/__init__.py

Line 3 in 16b122b

from dbt.adapters.redshift.relation import RedshiftColumn # noqa

Are you interested in contributing this feature?

Yep 👍

Anything else?

No response

[nssalian]

@dbeatty10, I can pick this up along with a similar change in dbt-core (postgres).

[dbeatty10]

@nssalian That sounds perfect! Here's the files to create or update:

• create: dbt-redshift/dbt/adapters/redshift/column.py
• update: dbt-redshift/dbt/adapters/redshift/relation.py
• update: dbt-redshift/dbt/adapters/redshift/init.py

Maybe there's more to it, but this is all I'm aware of currently.