Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional parameter for quoting db/schema #400

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Add an optional parameter for quoting db/schema #400

merged 1 commit into from
Dec 11, 2023

Conversation

b-per
Copy link
Collaborator

@b-per b-per commented Dec 11, 2023

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Closes #399

@dave-connors-3
Copy link
Collaborator

This looks good! do we expect ' and " to behave differently for different dbs? I think if not, I may prefer a boolean argument to that macro, and we add one or the other conditionally . otherwise 🚢

@b-per
Copy link
Collaborator Author

b-per commented Dec 11, 2023

I got the #400 one!

@b-per
Copy link
Collaborator Author

b-per commented Dec 11, 2023

Different DBs expect different quoting chars unfortunately. Thanks SQL.

Databricks is ` and Snowflake is " for example

@b-per b-per merged commit 6872d96 into main Dec 11, 2023
@b-per b-per deleted the fix/399 branch December 11, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databricks: print_dbt_project_evaluator_issues - quoting
2 participants