Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create empty no selection syntax provided to group command #81

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

dave-connors-3
Copy link
Collaborator

@dave-connors-3 dave-connors-3 commented Jun 26, 2023

closes #77

if no argument provided for selecting nodes, the group command will create an empty group in the project

@graciegoheen
Copy link
Collaborator

Why have it fail vs. create an empty group?

@dave-connors-3
Copy link
Collaborator Author

open to it! what's the benefit of an empty group?

@graciegoheen
Copy link
Collaborator

Maybe I want to start by creating an empty group and manually add models to it

@dave-connors-3
Copy link
Collaborator Author

@nicholasyager thought on this?

@nicholasyager
Copy link
Collaborator

🤔 Putting on my user shoes, I would expect that not supplying a selector would result in no selected models in the group. I do not think that people would intuitively expect all models to be added to a single group if no selector is provided.

@dave-connors-3 dave-connors-3 changed the title raise exception if no selection syntax provided to group command create empty no selection syntax provided to group command Jun 28, 2023
@dave-connors-3
Copy link
Collaborator Author

@nicholasyager @graciegoheen updated the logic to simply create an empty group without selection syntax!

Copy link
Collaborator

@nicholasyager nicholasyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dave-connors-3 This change looks both necessary and sufficient. Kudos for catching the test updates, too!

@dave-connors-3 dave-connors-3 merged commit 06892d2 into main Jun 29, 2023
@nicholasyager nicholasyager deleted the group-without-selection-syntax-error branch July 25, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default create-group with nothing selected, makes a group with all of your models
3 participants