Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve quotes in YML #66

Closed
1 of 5 tasks
dave-connors-3 opened this issue Jun 14, 2023 · 2 comments · Fixed by #88
Closed
1 of 5 tasks

preserve quotes in YML #66

dave-connors-3 opened this issue Jun 14, 2023 · 2 comments · Fixed by #88
Assignees
Labels
bug Something isn't working

Comments

@dave-connors-3
Copy link
Collaborator

Describe the bug

Our YAML provider seems to be dropping quotes from string properties:

image

Steps to reproduce

  1. have some strings in a yml file
  2. run an operation that interacts with that yml file
  3. check the formatting of the string object

Expected results

No YML should be edited that isn't directly related to the feature set being invoked by the package

Actual results

Errant YAML edits!

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: 🦆 )

The output of dbt debug:

❯ dbt debug
15:15:21  Running with dbt=1.5.1
15:15:21  dbt version: 1.5.1
15:15:21  python version: 3.10.10
15:15:21  python path: /Users/daveconnors/dev/sandbox/dbt-meshify-demo/.venv/bin/python3
15:15:21  os info: macOS-13.2.1-arm64-arm-64bit
15:15:21  Using profiles.yml file at /Users/daveconnors/dev/sandbox/dbt-meshify-demo/profiles.yml
15:15:21  Using dbt_project.yml file at /Users/daveconnors/dev/sandbox/dbt-meshify-demo/dbt_project.yml
15:15:21  Configuration:
15:15:21    profiles.yml file [OK found and valid]
15:15:21    dbt_project.yml file [OK found and valid]
15:15:21  Required dependencies:
15:15:21   - git [OK found]

15:15:21  Connection:
15:15:21    database: jaffle_shop
15:15:21    schema: analytics
15:15:21    path: ./reports/jaffle_shop.duckdb
15:15:21    Connection test: [OK connection ok]

15:15:21  All checks passed!

Are you interested in contributing the fix?

yes!

should be fairly easy!

@dave-connors-3 dave-connors-3 added bug Something isn't working triage Tis issue or pull request must be triaged by a project maintainer labels Jun 14, 2023
@dave-connors-3
Copy link
Collaborator Author

this test still runs properly with the edited yml, but IMO we should strive not to edit anything that we don't intend to

@b-per
Copy link
Contributor

b-per commented Jun 14, 2023

@nicholasyager nicholasyager self-assigned this Jun 26, 2023
@nicholasyager nicholasyager removed the triage Tis issue or pull request must be triaged by a project maintainer label Jun 26, 2023
@b-per b-per closed this as completed in #88 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants