Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm we want group command to add contracts to leaf nodes (current behavior) #159

Closed
graciegoheen opened this issue Sep 5, 2023 · 2 comments
Closed

Confirm we want group command to add contracts to leaf nodes (current behavior) #159

graciegoheen opened this issue Sep 5, 2023 · 2 comments

Comments

@graciegoheen
Copy link
Collaborator 

          Right now, it's also adding contracts to leaf nodes - is that expected?

Originally posted by @graciegoheen in #115 (comment)
@graciegoheen
Copy link
Collaborator Author

Note to self: if we only add contracts to models that are at the group-boundary (not leaf models) - i will need to update my examples because the group selection syntax doesn't include a group-boundary node (only the transactions model with is a leaf)

@graciegoheen
Copy link
Collaborator Author

Should these nodes be public or protected?

@graciegoheen graciegoheen mentioned this issue Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graciegoheen @dave-connors-3