Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2813] Begin compiling filter attrs on Metric nodes #8065

Closed
Tracked by #7498
QMalcolm opened this issue Jul 10, 2023 · 1 comment
Closed
Tracked by #7498

[CT-2813] Begin compiling filter attrs on Metric nodes #8065

QMalcolm opened this issue Jul 10, 2023 · 1 comment
Assignees
Labels
semantic Issues related to the semantic layer

Comments

@QMalcolm
Copy link
Contributor

Acceptance Criteria

• Complicated user defined metric filters get compiled down to the protocol definition of WhereFilters

Context

We realized recently that filters were basically unconstrained highly structured objects within the semantic layer protocols defined in dbt-semantic-interfaces. We're currently racing to resolve this issue in DSI as defined in DSI#102. We're well on our way to resolving DSI#102 and have a draft PR. In this we define a generic WhereFilterCompiler. which can compile a user specified filter down to a WhereFilter protocol implementation. Once this is merged and released (soon 🤞), we should instantiate a WhereFilterCompiler in the MetricParser and compile the filters at that time.

@QMalcolm QMalcolm added the semantic Issues related to the semantic layer label Jul 10, 2023
@QMalcolm QMalcolm added this to the v1.6 milestone Jul 10, 2023
@github-actions github-actions bot changed the title Begin compiling filter attrs on Metric nodes [CT-2813] Begin compiling filter attrs on Metric nodes Jul 10, 2023
@QMalcolm
Copy link
Contributor Author

Instead of going the DSI#102 route, we ended up going the DSI#109 route for ensuring filter structure changes in the protocol. Additionally we began supporting the change of DSI#109 in #8085. So this can be considered done 🙂

@jtcohen6 jtcohen6 removed this from the v1.6 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semantic Issues related to the semantic layer
Projects
None yet
Development

No branches or pull requests

2 participants