Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2724] [Feature] Add negative test case for the split_part macro #7915

Closed
3 tasks done
Tracked by #7916
dbeatty10 opened this issue Jun 21, 2023 · 0 comments · Fixed by #7200
Closed
3 tasks done
Tracked by #7916

[CT-2724] [Feature] Add negative test case for the split_part macro #7915

dbeatty10 opened this issue Jun 21, 2023 · 0 comments · Fixed by #7200
Labels
enhancement New feature or request Team:Adapters Issues designated for the adapter area of the code

Comments

@dbeatty10
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

The issue described in dbt-labs/dbt-bigquery#615 is more general than dbt-bigquery, and the best way to support it is by adding a test cases for a negative index within dbt-core.

Describe alternatives you've considered

An option:

  • each adapter maintainer is completely on their own to create test cases that include negative indices

This doesn't sound good for anyone, so let's go with Plan A!

Who will this benefit?

This will benefit both adapter maintainers and downstream users of the split_part macro.

Are you interested in contributing this feature?

🦞 is on it

Anything else?

No response

@dbeatty10 dbeatty10 added enhancement New feature or request triage labels Jun 21, 2023
@github-actions github-actions bot changed the title [Feature] Add negative test case for the split_part macro [CT-2724] [Feature] Add negative test case for the split_part macro Jun 21, 2023
@dbeatty10 dbeatty10 added Team:Adapters Issues designated for the adapter area of the code and removed triage labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant