Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2347] [Bug] Petite laideur in v1.5 logging: datetimes #7255

Closed
jtcohen6 opened this issue Apr 1, 2023 · 1 comment · Fixed by #7257
Closed

[CT-2347] [Bug] Petite laideur in v1.5 logging: datetimes #7255

jtcohen6 opened this issue Apr 1, 2023 · 1 comment · Fixed by #7257
Assignees
Labels
bug Something isn't working logging
Milestone

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 1, 2023

Since the switch to the new proto library, datetimes are ugly-rendered in text-formatted logging, and they take up more space than they should:

Timing info for seed.test.my_seed (execute): seconds: 1680366677
nanos: 785534000
 => seconds: 1680366680
nanos: 375668000
Command `dbt clone` succeeded at seconds: 1680366681
nanos: 79572000
 after 7.66 seconds

From looking at the JSON-formatted logs, this also shows up in the message field. Let's pretty-stringify these datetime values wherever they're being f-string formatted into message.

@jtcohen6 jtcohen6 added bug Something isn't working logging labels Apr 1, 2023
@jtcohen6 jtcohen6 added this to the v1.5 milestone Apr 1, 2023
@jtcohen6 jtcohen6 self-assigned this Apr 1, 2023
@github-actions github-actions bot changed the title Petitess laideurs in v1.5 logging [CT-2347] Petitess laideurs in v1.5 logging Apr 1, 2023
@jtcohen6 jtcohen6 changed the title [CT-2347] Petitess laideurs in v1.5 logging [CT-2347] Petite laideur in v1.5 logging: timestamps Apr 1, 2023
@jtcohen6 jtcohen6 changed the title [CT-2347] Petite laideur in v1.5 logging: timestamps [CT-2347] Petite laideur in v1.5 logging: datetimes Apr 1, 2023
@jtcohen6 jtcohen6 changed the title [CT-2347] Petite laideur in v1.5 logging: datetimes [CT-2347] Petites laideurs in v1.5 logging: datetimes, "unable to parse dict" Apr 4, 2023
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Apr 4, 2023

Just ran into this one as well, during dbt deps:

14:45:21  [DepsNotifyUpdatesAvailable]: Unable to parse dict {'packages': ['dbt-labs/audit_helper', 'dbt-labs/dbt_external_tables', 'dbt-labs/metrics', 'entechlog/dbt_snow_mask', 'fivetran/hubspot', 'mjirv/dbt_datamocktool', 'fivetran/hubspot_source']}
14:45:21  Updates available for packages: []

Update: Already fixed by #7262!

@jtcohen6 jtcohen6 changed the title [CT-2347] Petites laideurs in v1.5 logging: datetimes, "unable to parse dict" [CT-2347] Petite laideur in v1.5 logging: datetimes Apr 5, 2023
@jtcohen6 jtcohen6 changed the title [CT-2347] Petite laideur in v1.5 logging: datetimes [CT-2347] [Bug] Petite laideur in v1.5 logging: datetimes Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant