You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
github-actionsbot
changed the title
TODO: Validation: disallow access:private on ungrouped model
[CT-2195] TODO: Validation: disallow access:private on ungrouped model
Feb 27, 2023
MichelleArk
changed the title
[CT-2195] TODO: Validation: disallow access:private on ungrouped model
[CT-2195] Validation: disallow access:private on ungrouped model
Feb 27, 2023
When ParsedNode.patch is called the group might not be set yet. "patch" is called before "update_node_config", so access is set before group. This is another one of those problems of having to coordinate validation across nodes and node configs. Which actually might be simplified if we get rid of separate node configs.
I don't think this is a MUST for Phase 1. It will save users some confusion if they try to ref an ungrouped private model, but it should yield the same result at the end of the day, which is that private models are useless unless in an explicit group.
jtcohen6
changed the title
[CT-2195] Validation: disallow access:private on ungrouped model
[CT-2195] [Feature] Validation: disallow access:private on ungrouped model
Apr 30, 2023
Closing as not planned with the same rationale as #7687:
@jtcohen6: I don't expect people to run into this, unless they're trying to do interesting things, and we shouldn't stand in their way within the code. We should document this as a limitation, and we can revisit if it causes major confusion / UX issues.
Models without a group, and with
access
set toprivate
should raise an error at parse-time.ParsedNode.patch could be the right spot for this validation, since group information should be available at this point.
The text was updated successfully, but these errors were encountered: