Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2195] [Feature] Validation: disallow access:private on ungrouped model #7063

Closed
Tracked by #6747
MichelleArk opened this issue Feb 27, 2023 · 3 comments
Closed
Tracked by #6747
Labels
enhancement New feature or request model_groups_access Issues related to groups multi_project

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Feb 27, 2023

Models without a group, and with access set to private should raise an error at parse-time.

models: 
- name: model
  access: private

ParsedNode.patch could be the right spot for this validation, since group information should be available at this point.

@github-actions github-actions bot changed the title TODO: Validation: disallow access:private on ungrouped model [CT-2195] TODO: Validation: disallow access:private on ungrouped model Feb 27, 2023
@MichelleArk MichelleArk changed the title [CT-2195] TODO: Validation: disallow access:private on ungrouped model [CT-2195] Validation: disallow access:private on ungrouped model Feb 27, 2023
@gshank
Copy link
Contributor

gshank commented Feb 27, 2023

When ParsedNode.patch is called the group might not be set yet. "patch" is called before "update_node_config", so access is set before group. This is another one of those problems of having to coordinate validation across nodes and node configs. Which actually might be simplified if we get rid of separate node configs.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Mar 3, 2023

I don't think this is a MUST for Phase 1. It will save users some confusion if they try to ref an ungrouped private model, but it should yield the same result at the end of the day, which is that private models are useless unless in an explicit group.

@jtcohen6 jtcohen6 added the enhancement New feature or request label Apr 30, 2023
@jtcohen6 jtcohen6 changed the title [CT-2195] Validation: disallow access:private on ungrouped model [CT-2195] [Feature] Validation: disallow access:private on ungrouped model Apr 30, 2023
@MichelleArk
Copy link
Contributor Author

Closing as not planned with the same rationale as #7687:

@jtcohen6: I don't expect people to run into this, unless they're trying to do interesting things, and we shouldn't stand in their way within the code. We should document this as a limitation, and we can revisit if it causes major confusion / UX issues.

@MichelleArk MichelleArk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request model_groups_access Issues related to groups multi_project
Projects
None yet
Development

No branches or pull requests

3 participants