Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1908] [Regression] exposure_content referenced incorrectly #6738

Closed
2 tasks done
Mathyoub opened this issue Jan 26, 2023 · 1 comment · Fixed by #6739
Closed
2 tasks done

[CT-1908] [Regression] exposure_content referenced incorrectly #6738

Mathyoub opened this issue Jan 26, 2023 · 1 comment · Fixed by #6739
Assignees
Labels
bug Something isn't working regression
Milestone

Comments

@Mathyoub
Copy link
Contributor

Is this a regression in a recent version of dbt-core?

  • I believe this is a regression in dbt-core functionality
  • I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior

local variable 'exposure_content' referenced before assignment error due to exposure_content being referenced instead of source_content

Expected/Previous Behavior

This is new in 1.4.0
dbt deps will not fail with error above

Steps To Reproduce

  • you're doing state comparison (--state <old_manifest>)
    or
  • your old project has sources defined in it (our automated test for cross-version state comparison compatibility does not include sources)

Relevant log output

see current behavior

Environment

- OS:
- Python:
- dbt (working version): 1.3.2
- dbt (regression version): 1.4.0

Which database adapter are you using with dbt?

No response

Additional Context

No response

@Mathyoub Mathyoub added bug Something isn't working triage regression labels Jan 26, 2023
@github-actions github-actions bot changed the title [Regression] exposure_content referenced incorrectly [CT-1908] [Regression] exposure_content referenced incorrectly Jan 26, 2023
@leahwicz leahwicz removed the triage label Jan 26, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 26, 2023

Specifically, this would affect any project with sources defined, that is doing a manifest comparison across v1.3 → v1.4. If their last dbt run was on v1.3 (or earlier), and they use a manifest from that run in a state:modified run with v1.4, they will run into this error.

This method exists to make that cross-version comparison possible. There was a bug in the method.

To catch this in the future, let's update this automated test to include a complex project, with more resource types: https://github.com/dbt-labs/dbt-core/blob/main/tests/functional/artifacts/test_previous_version_state.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants