Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1604] Remove Compiled Node classes #6383

Closed
gshank opened this issue Dec 5, 2022 · 0 comments · Fixed by #6384
Closed

[CT-1604] Remove Compiled Node classes #6383

gshank opened this issue Dec 5, 2022 · 0 comments · Fixed by #6384
Milestone
v1.4

Comments

@gshank
Copy link
Contributor

gshank commented Dec 5, 2022

As part of the structured logging updates, we are creating proto definitions for node output. Having separate "Parsed" and "Compiled" classes complicates this and also complicates the code.

Remove the core/dbt/contracts/graph/compiled.py file and references to it.

Remove "Parsed" from the Parsed node classes, so that they are ModelNode, SnapshotNode, etc.
@github-actions github-actions bot changed the title Remove Compiled Node classes [CT-1604] Remove Compiled Node classes Dec 5, 2022
@gshank gshank mentioned this issue Dec 5, 2022
Merged
6 tasks
@jtcohen6 jtcohen6 added this to the v1.4 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

CT 1604 remove compiled classes dbt-labs/dbt-core
2 participants
@gshank @jtcohen6