You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a category to the exceptions that can be logged
organize exceptions better in the file to be grouped by where they are triggered - ideally these could be split out into the directory they are raised but out of scope for now
When the exception gets raised, pass in the parameters needed to build the message when possible
Make sure these changes get trickled into adapters
Questions
Some exceptions build custom messages when raised. Should those be custom exceptions or continue to work as is.
Is an exception category its own thing or is it just another category at the top level of logs
The jinja context exceptions needs to persists. Could they live elsewhere? Should they?
The text was updated successfully, but these errors were encountered:
I would surmise from 1 that part of the work is get rid of bare adhoc exceptions too, right? Does this statement imply you are more keen on passing classes around that encode messages, like with error_or_warn? If so, you sure have my ax vote.
I'm proposing we move more toward a model like IncompatibleSchemaException where the message is built within the exception class instead of being built and then passed in. I don't know yet if this is possible for every single exception. That's part of the purpose of this task.
We're on same page! I was referring to raises on bare strings. I get some may not be able to converted, but I'm glad it's a priority to standardize what we can.
a precursor to #5958
There are a few goals here
Questions
The text was updated successfully, but these errors were encountered: