Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1368] New tracking event: Project ID #6098

Closed
Tracked by #7162 ...
iknox-fa opened this issue Oct 18, 2022 · 5 comments · Fixed by #7231
Closed
Tracked by #7162 ...

[CT-1368] New tracking event: Project ID #6098

iknox-fa opened this issue Oct 18, 2022 · 5 comments · Fixed by #7231
Assignees
Labels

Comments

@iknox-fa
Copy link
Contributor

iknox-fa commented Oct 18, 2022

We currently try to get the project ID for tracking purposes long before we actually load the project-- this causes a bunch of issues where we have to parse projects and such just to track the invocation. Since there's no benefit to this in terms of our analytics, this approach has been changed in this PR.

This ticket encompasses the work necessary to properly report the project ID at such a point that we actually load the project. This includes the work to update the internal analytics project to reflect the change in raw event data.

Specifically we need project_id as indicated here.

@jtcohen6
Copy link
Contributor

This includes the work to update the internal analytics project to reflect the change in raw event data.

For simplicity, let's kick this out of scope for here, and open a new issue in our internal-analytics repo instead to track this as follow-up work: https://github.com/dbt-labs/internal-analytics/issues/1402

@iknox-fa
Copy link
Contributor Author

iknox-fa commented Mar 23, 2023

@jtcohen6 I was working on this, and I realized we already have the project id as part of the timing context. Would it make sense to source it from there as opposed to invoking another snowplow event?

@jtcohen6
Copy link
Contributor

jtcohen6 commented Mar 23, 2023

@iknox-fa Good find!

While that should work for the vast majority of cases, I think we want to guarantee that we have project_id tracked for 100% of invocations*. My sense is that, a programmatic invocation that passes in a manifest (and therefore doesn't call get_full_manifest) would never fire that event, and so we'd be missing it for that invocation. That's a pattern we might be pursuing with dbt-server.

*unless the user has opted out of tracking, of course

@iknox-fa
Copy link
Contributor Author

Ah Ok that makes sense. A new event it is!

@jtcohen6
Copy link
Contributor

Resolved by #7231!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants