Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1312] [Bug] disabled flag not implemented for some metrics error messages #6023

Closed
2 tasks done
emmyoop opened this issue Oct 7, 2022 · 0 comments · Fixed by #6024
Closed
2 tasks done

[CT-1312] [Bug] disabled flag not implemented for some metrics error messages #6023

emmyoop opened this issue Oct 7, 2022 · 0 comments · Fixed by #6024
Assignees
Labels
bug Something isn't working
Milestone

Comments

@emmyoop
Copy link
Member

emmyoop commented Oct 7, 2022

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

exceptions.py has a lot of duplicated errors for source_target_not_found, metric_target_not_found and exposure_target_not_found. exposure_target_not_found is actually not needed since an exposure is never a target.

Additionally, metric_target_not_found was not passing in disabled so the error message would never explicitly say it was disabled, it instead included the less specific wording was not found or is disabled.

This was noticed while working on #5957. It feels separate from that work, but related. Doing as a separate PR to reduce PR size for #5957.

Expected Behavior

Exceptions are simpler produce specific messages.

@emmyoop emmyoop added the bug Something isn't working label Oct 7, 2022
@emmyoop emmyoop self-assigned this Oct 7, 2022
@github-actions github-actions bot changed the title [Bug] disabled flag not implemented for some metrics error messages [CT-1312] [Bug] disabled flag not implemented for some metrics error messages Oct 7, 2022
@emmyoop emmyoop mentioned this issue Oct 7, 2022
6 tasks
@jtcohen6 jtcohen6 added this to the v1.4 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants