Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mypy pass from the command line #5983

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Make mypy pass from the command line #5983

merged 5 commits into from
Oct 11, 2022

Conversation

max-sixty
Copy link
Contributor

@max-sixty max-sixty commented Oct 2, 2022 •
edited by lostmygithubaccount
Loading

Similar issue to #5947 (which this includes, and so requires merging #5947 first) — currently running mypy from the command line fails, because the configs are in .pre-commit-config.yaml, which isn't available to editors etc.

Description

closes #6029

Checklist

@max-sixty max-sixty requested a review from a team as a code owner October 2, 2022 21:12
@max-sixty max-sixty requested review from stu-k and VersusFacit October 2, 2022 21:12
@cla-bot cla-bot bot added the cla:yes label Oct 2, 2022
@leahwicz leahwicz requested review from iknox-fa and removed request for stu-k and VersusFacit October 3, 2022 12:32
@max-sixty max-sixty mentioned this pull request Oct 7, 2022
Closed
3 tasks
@lostmygithubaccount lostmygithubaccount added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering support_rotation A good task to pick up during support rotation labels Oct 7, 2022
emmyoop
emmyoop requested changes Oct 11, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
emmyoop
emmyoop approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @max-sixty! Really appreciate the contribution here!

@emmyoop emmyoop merged commit 3d09531 into dbt-labs:main Oct 11, 2022
@max-sixty max-sixty deleted the mypy-config branch October 11, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering support_rotation A good task to pick up during support rotation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1315] [Internal] Make mypy pass from the command line
3 participants
@max-sixty @emmyoop @lostmygithubaccount