Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1042] Improve unhelpful log line checks #5658

Closed
nathaniel-may opened this issue Aug 16, 2022 · 0 comments · Fixed by #5659
Closed

[CT-1042] Improve unhelpful log line checks #5658

nathaniel-may opened this issue Aug 16, 2022 · 0 comments · Fixed by #5659
Assignees
@nathaniel-may
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented Aug 16, 2022 •
edited
Loading

It was discovered in #5654 which failed the log line interop tests during development that the tests don't print out the line that failed the test which makes debugging these failures near impossible. More information about the failure should be printed during testing.
@nathaniel-may nathaniel-may added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Aug 16, 2022
@nathaniel-may nathaniel-may self-assigned this Aug 16, 2022
@github-actions github-actions bot changed the title Improve unhelpful log line checks [CT-1042] Improve unhelpful log line checks Aug 16, 2022
@nathaniel-may nathaniel-may mentioned this issue Aug 16, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathaniel-may nathaniel-may

Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print more information on log line interop test failures dbt-labs/dbt-core
1 participant
@nathaniel-may