Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-847] [Feature] Support grant-based node selection #5482

Closed
1 task done
dataders opened this issue Jul 15, 2022 · 4 comments · Fixed by #5889
Closed
1 task done

[CT-847] [Feature] Support grant-based node selection #5482

dataders opened this issue Jul 15, 2022 · 4 comments · Fixed by #5889
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes
Milestone
v1.3

Comments

@dataders
Copy link
Contributor

Is this your first time opening an issue?

Describe the Feature

a user should be able to, for the DAG subset of relations where the user [email protected] has SELECT access:

  • run exactly said subset, and
  • filter dbt docs to said subset

The fix is this one-line change

Describe alternatives you've considered

No response

Who will this benefit?

Everyone!

Are you interested in contributing this feature?

sure?

Anything else?

No response
@dataders dataders added enhancement New feature or request triage labels Jul 15, 2022
@github-actions github-actions bot changed the title [Feature] Support grant-based node selection [CT-847] [Feature] Support grant-based node selection Jul 15, 2022
@dataders dataders added this to the v1.3 milestone Jul 15, 2022
@dataders dataders added the Team:Adapters Issues designated for the adapter area of the code label Jul 15, 2022
@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Jul 17, 2022
@jtcohen6
Copy link
Contributor

Thanks for opening @dataders! I think this could be a good_first_issue, though we'll also want a test or two :)

filter dbt docs to said subset

This will require another small change, in dbt-docs, possibly hereabouts

@stefansaint
Copy link

I am taking a look at picking up this issue unless @dataders you're wanting to see this one through :)

@dataders
Copy link
Contributor Author

All you @Kip620! Appreciate your initiative.

@jtcohen6 jtcohen6 added Team:Execution node selection Functionality and syntax for selecting DAG nodes and removed Team:Adapters Issues designated for the adapter area of the code labels Sep 19, 2022
This was referenced Sep 20, 2022
Closed
Merged
@jtcohen6
Copy link
Contributor

resolved by #5889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

ConfigSelectorMethod should check for bools danielcmessias/dbt-core
3 participants
@dataders @jtcohen6 @stefansaint