You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The timing array in run_results.json makes it possible to see the exact timestamps when a model started/finished compiling and executing. The array appears to be entirely empty if the resource encounters a runtime error.
What users see in run_results.json, for an error model vs. a success model:
The collect_timing_info context manager updates the timing_info attribute on self. However, it never appends timing_info above if self.run encounters an error (e.g. a database error):
github-actionsbot
changed the title
Detailed timing info not collected for models with error status
[CT-846] Detailed timing info not collected for models with error status
Jul 15, 2022
Detailed timing information (including timestamps) would be available from the structured logging interface, which is where we're investing more of our effort around dbt Core metadata going forward
Even though the response object is available from failing queries, because of the way we try materialization macros and bubble up any exceptions, we don't plumb the adapter_response back up to the run result object.
The
timing
array inrun_results.json
makes it possible to see the exact timestamps when a model started/finished compiling and executing. The array appears to be entirely empty if the resource encounters a runtime error.What users see in
run_results.json
, for anerror
model vs. asuccess
model:The relevant code is here, in the
compile_and_execute
method:dbt-core/core/dbt/task/base.py
Lines 336 to 340 in f988f76
The
collect_timing_info
context manager updates thetiming_info
attribute onself
. However, it never appendstiming_info
above ifself.run
encounters an error (e.g. a database error):The resolution to this bug would find a way to return/append/update the
timing_info
array even when the model encounters an error during its build.The text was updated successfully, but these errors were encountered: