Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-653] [Feature] Allow running unit/integration tests locally with any supported Python version #5257

Closed
1 task done
jwills opened this issue May 16, 2022 · 1 comment · Fixed by #5269
Closed
1 task done
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@jwills
Copy link
Contributor

jwills commented May 16, 2022

Is this your first time opening an issue?

Describe the Feature

This is more of a rough edge for a non-professional dbt-core developer: the Makefile hard-codes py38 as the preferred python version in tox for running unit tests and integration tests; we use Python 3.9 at my day job, so when I need to do work on dbt-core I need to remember to swap out the version in the Makefile to py39 before I run dbt tests and then switch it back before I send a PR upstream.

Describe alternatives you've considered

I would love it if the Makefile was either a) configured to work with the Python version that I had installed locally as long as it was supported (i.e., if the default in the Makefile was py and py-integration instead of py38 and py38-integration), or, if that presents a problem for e.g. CI or some such thing, if it was easy (like via an environment variable that was documented in the CONTRIBUTING.md guide) for me to override the setting in the Makefile on my local machine.

Who will this benefit?

Developers who want to create PRs for dbt-core who do not work at dbt Labs.

Are you interested in contributing this feature?

Happy to!

Anything else?

Issue originally discussed in a Slack thread in dbt-core-development: https://getdbt.slack.com/archives/C50NEBJGG/p1652466095907019

@jwills jwills added enhancement New feature or request triage labels May 16, 2022
@github-actions github-actions bot changed the title [Feature] Allow running unit/integration tests locally with any supported Python version [CT-653] [Feature] Allow running unit/integration tests locally with any supported Python version May 16, 2022
@jtcohen6
Copy link
Contributor

Using py and py-integration makes tons of sense—it will just uses your own local PATH version of Python, right?

We don't use the Makefile in CI (we hit tox directly), so I don't think there should be any implications there. Let's do a nice thing for non-professional dbt-core developers :)

The only edge I could see is someone very eagerly upgrading to a new minor version of Python, before dbt-core officially supports it, e.g. Python 3.10 prior to the v1.1 release. But I'd like to see us supporting new Python minor versions more proactively going forward, especially when they promise to have some good stuff inside...

@jwills proceed at your leisure!

@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
2 participants