Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-402] Randomly failing test: test_hard_delete_snapshot.py #4916

Closed
gshank opened this issue Mar 21, 2022 · 1 comment · Fixed by #5020
Closed

[CT-402] Randomly failing test: test_hard_delete_snapshot.py #4916

gshank opened this issue Mar 21, 2022 · 1 comment · Fixed by #5020
Assignees

Comments

@gshank
Copy link
Contributor

gshank commented Mar 21, 2022

The failing test seems to be a 1 second difference between 2 timestamps in tests/functional/simple_snapshot/test_hard_delete_snapshot.py just for one Python/ OS combo

        )

E assert datetime.datetime(2022, 3, 21, 19, 39, 23, tzinfo=) >= datetime.datetime(2022, 3, 21, 19, 39, 24, tzinfo=)
E + where datetime.datetime(2022, 3, 21, 19, 39, 23, tzinfo=) = <built-in method replace of datetime.datetime object at 0x7f0793efc780>(tzinfo=)
E + where <built-in method replace of datetime.datetime object at 0x7f0793efc780> = datetime.datetime(2022, 3, 21, 19, 39, 23).replace
E + and = pytz.UTC
E + and datetime.datetime(2022, 3, 21, 19, 39, 24, tzinfo=) = <built-in method replace of datetime.datetime object at 0x7f0794198900>(microsecond=0)
E + where <built-in method replace of datetime.datetime object at 0x7f0794198900> = datetime.datetime(2022, 3, 21, 19, 39, 24, 2693, tzinfo=).replace

/home/runner/work/dbt-core/dbt-core/tests/functional/simple_snapshot/test_hard_delete_snapshot.py:146: AssertionError

@github-actions github-actions bot changed the title Randomly failing test: test_hard_delete_snapshot.py [CT-402] Randomly failing test: test_hard_delete_snapshot.py Mar 21, 2022
@nathaniel-may
Copy link
Contributor

estimation:

  • the failure implies an actual underlying bug
  • should at least mark as flaky in the meantime, but that is not a fix.
  • 1 day spike instead of estimation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants