-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-91] Separate serialization for internal use and for artifacts with published schemas #4617
Comments
Sorry for adding my 2 cents. I think these should be different data classes entirely. I don't think the same data class that is used for internal purposes should be used to write external artifacts. We can using mapping to go from internal representation <--> external representation and only the external representation needs to care about serialization. I think there is a path forward here that does not involve the (in)famous "hologram" package as well. Happy to provide examples when thinking about this more! |
Moving away from |
The original prompt/motivation for this issue:
I'm interested in any small, tactical lifts we can make so that we're not bumping the manifest schema version in every single new minor version. At the same time, we're eager to provide other interfaces into manifest information, over which we have more control: #4807 |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers. |
Closing this one because things have changed and we are looking to create artifacts off of the protobuf schemas |
Right now we use the same serialization for creating the partial_parse.msgpack file, and the manifest.json (and other artifacts). In some cases we need an attribute in internal processing but it's not necessary for the manifest.json, but implementing the attribute means we have to update the published json schema.
Investigate ways to have different serialization. One possibility: we use an 'omit_none' flag that gets passed along for serialization. Perhaps we could implement a similar flag for artifacts.
The goal would be to implement this for 1.1.0.
The text was updated successfully, but these errors were encountered: