Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-39] Bug: ensure that dump_graph is not run for logging events in cachy.py unless cache logging is turned on #4569

Closed
gshank opened this issue Jan 13, 2022 · 0 comments · Fixed by #4619 or #4660

Comments

@gshank
Copy link
Contributor

gshank commented Jan 13, 2022

We skip actual logging of core/dbt/adapters/cache.py in core/dbt/events/functions.py fire_event, but that doesn't prevent the actual 'dump_graph' call from executing, which is a performance problem.

In 0.21 we used a 'lazy_log' function to skip those events. We should re-implement something like that to prevent the overhead of these calls.

@gshank gshank added this to the v1.0.2 milestone Jan 13, 2022
@github-actions github-actions bot changed the title Bug: ensure that 'dump_graph' is not run for logging events in cachy.py unless cache logging is turned on [CT-39] Bug: ensure that dump_graph is not run for logging events in cachy.py unless cache logging is turned on Jan 13, 2022
@nathaniel-may nathaniel-may self-assigned this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment