Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-28] Spike moving dbt to a binary installation #4558

Closed
nathaniel-may opened this issue Jan 7, 2022 · 6 comments
Closed

[CT-28] Spike moving dbt to a binary installation #4558

nathaniel-may opened this issue Jan 7, 2022 · 6 comments
Labels
enhancement New feature or request install spike stale Issues that have gone stale

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented Jan 7, 2022

We should explore the tradeoffs for moving from pip installing source to distributing a binary. We would bundle one version of the Python interpreter to run the Python source code.

Pros

  • No more maintaining python compatibility for old versions
  • dbt developers and maintainers get access to the latest Python features
  • Users won't be subject to experiencing strange behaviors while using unsupported, newer versions of Python, and also won't log that class of ticket anymore.
  • Significantly less CI steps to run
  • Debugging has one less dimension to check for developers and the support team
  • Solidifies interface boundaries because consumers of dbt would no longer be able to directly call arbitrary parts of dbt
  • pip install could still work if we distribute the dbt binary as a wheel.
  • All installs of the same dbt version use the same versions of dependencies that went through our CI regardless of the version ranges we specify in dbt source.

Cons

  • Consumers of dbt would no longer be able to directly call arbitrary parts of dbt, which would require consumers currently relying on this strategy to use the proper interfaces before upgrading.
  • Our current strategy for plugins is to rely on pip placing code inside dbt-core with directory matching which would no longer work. A new strategy would need to be explored and decided on. One possible alternative is to have adapters be the single point of install where each adapter depends on a specific version of dbt core.

Issues

A small sample of issues this packaging strategy would prevent:

@nathaniel-may nathaniel-may added enhancement New feature or request triage labels Jan 7, 2022
@github-actions github-actions bot changed the title Spike moving dbt to a binary installation [CT-28] Spike moving dbt to a binary installation Jan 7, 2022
@nathaniel-may
Copy link
Contributor Author

An example of a user issue that would be eliminated by this packaging strategy: #4564

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Aug 18, 2022
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

@leahwicz leahwicz removed the stale Issues that have gone stale label Aug 26, 2022
@leahwicz leahwicz reopened this Aug 26, 2022
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Feb 23, 2023
@emmyoop emmyoop removed the stale Issues that have gone stale label Feb 23, 2023
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Aug 23, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request install spike stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

4 participants